refactor: remove act from chunk and soc api - #5572
Conversation
| return | ||
| } | ||
|
|
||
| address := paths.Address |
There was a problem hiding this comment.
We removed ACT from POST /chunks, but GET /chunks/{address} and HEAD /chunks/{address} are still wrapped with s.actDecryptionHandler() in pkg/api/router.go, and chunkGetHandler / hasChunkHandler still have the context address resolution:
if v := getAddressFromContext(r.Context()); !v.IsZero() {
address = v
}Additionally, openapi/Swarm.yaml still lists Swarm-Act-Timestamp, Swarm-Act-Publisher, and Swarm-Act-History-Address on GET /chunks/{address} and HEAD /chunks/{address}.
If ACT is fundamentally unsupported on raw chunks because they are unencrypted and low-level, shouldn't we remove ACT middleware and parameters from GET and HEAD /chunks/{address} as well? Otherwise, we have an asymmetrical API that accepts ACT on download/head but not upload, without any test coverage.
There was a problem hiding this comment.
The ACT headers remain on GET/HEAD /chunks/{address} by design. These requests go through actDecryptionHandler, the same middleware used by GET/HEAD /bytes/{address} and /bzz/{address}/{path}.
This middleware is required to resolve ACT wrapped addresses to their actual addresses when the content was encrypted during upload through POST /bytes or POST /bzz.
Accessing chunks from such encrypted uploads through the low level chunk API is still a valid use case, so the decryption path must remain.
| default: | ||
| description: Default response | ||
|
|
||
| "/chunks/{address}": |
There was a problem hiding this comment.
Under GET /chunks/{address} and HEAD /chunks/{address}, the ACT parameters are still present:
SwarmActTimestamp
SwarmActPublisher
SwarmActHistoryAddress
If we are cleaning up ACT from the chunks API, these should be removed from the OpenAPI spec as well (along with removing actDecryptionHandler from router.go).
There was a problem hiding this comment.
Same as above:
The ACT headers remain on GET/HEAD /chunks/{address} by design. These requests go through actDecryptionHandler, the same middleware used by GET/HEAD /bytes/{address} and /bzz/{address}/{path}.
This middleware is required to resolve ACT wrapped addresses to their actual addresses when the content was encrypted during upload through POST /bytes or POST /bzz.
Accessing chunks from such encrypted uploads through the low level chunk API is still a valid use case, so the decryption path must remain.
4 participants
Checklist
Description
Remove ACT support from /chunks and /soc
ACT never worked correctly on these two endpoints, the data isn't encrypted and, for /soc, there's no way to decrypt the reference back. Removed Swarm-Act handling from both, bumped the API version, and updated tests accordingly.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#5469
Screenshots (if appropriate):
AI Disclosure