-
Notifications
You must be signed in to change notification settings - Fork 49
Draft: lighteval converter (for #189) #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Mandark-droid
wants to merge
8
commits into
evaleval:main
Choose a base branch
from
Mandark-droid:draft/lighteval-converter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ca80e7c
feat: add lighteval converter
Mandark-droid 75a03c2
fix(lighteval): name tasks skipped for having no finite score
Mandark-droid deb0b8d
fix(lighteval): address review-anvil findings on identity, credential…
Mandark-droid 8e827ab
Merge main into the lighteval draft
borgr 6d35281
feat(lighteval): convert per-sample details into instance-level output
borgr e58400c
test(lighteval): pin details conversion to a run lighteval produced i…
borgr 927da0d
ci: ask each new lighteval release to produce a run, weekly
borgr f2edb28
fix(lighteval): redact inference_server_auth, the field upstream name…
Mandark-droid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: Upstream smoke | ||
|
|
||
| # Asks the *current* upstream release to produce a run, then converts it. The | ||
| # committed fixtures pin a past release, so only this can tell us that a new one | ||
| # renamed a field or moved a file. | ||
| # | ||
| # Deliberately not on pull_request: an upstream release should not turn an | ||
| # unrelated PR red, and a scheduled failure names the version that broke it. | ||
| on: | ||
| schedule: | ||
| # Mondays, 06:37 UTC. | ||
| - cron: '37 6 * * 1' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| lighteval: | ||
| name: lighteval | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - uses: actions/checkout@v6.0.2 | ||
| - uses: astral-sh/setup-uv@v7.6.0 | ||
| - name: Run lighteval's fake model, convert it, validate it | ||
| # lighteval is installed ad hoc and never enters the project or the | ||
| # lockfile: it requires datasets>=4 while crfm-helm pins datasets~=3.1, | ||
| # so a locked dependency would make the whole resolution unsatisfiable. | ||
| # The `lighteval` extra here is only pyarrow, which does not conflict. | ||
| # | ||
| # UV_TORCH_BACKEND=cpu keeps a CUDA torch off a CPU runner; the model is | ||
| # fake, so no torch device is used at all. | ||
| env: | ||
| UV_PROJECT_ENVIRONMENT: ${{ runner.temp }}/eee-venv | ||
| UV_TORCH_BACKEND: cpu | ||
| HF_HUB_DISABLE_PROGRESS_BARS: '1' | ||
| run: >- | ||
| uv run -p 3.12 --extra lighteval --with lighteval | ||
| python scripts/upstream_smoke/lighteval_smoke.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAV-RUN1-R1-F008 [medium] failure-reporting — The single-file branch calls
transform_from_filebefore it creates aSourceConversionResult. Parse or conversion errors exit non-zero, but the structured failure report is never saved; directory input reports the same failure class correctly.A small lighteval-local file-result path can give both entry modes the same report-before-raise behavior.