Skip to content

Fix Eval Manager Python boolean syntax #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moneyparking merged 2 commits into from
Oct 1, 2026
Merged

Fix Eval Manager Python boolean syntax #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f0c9f3
fix: restore valid Eval Manager boolean syntax
moneyparking Oct 1, 2026
135bb1a
test: compile Eval Manager before contract tests
moneyparking Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/eval-manager-selftest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: "3.11"
- name: Compile Eval Manager sources
run: python -m compileall -q eval-manager
- name: Run Eval Manager contract tests
run: |
python eval-manager/test_eval_manager.py
Expand Down
2 changes: 1 addition & 1 deletion eval-manager/eval_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def _verify_freeze(contract: dict[str, Any], repo_root: Path) -> list[dict[str,
raise ContractError(
"freeze.source_ref must be refs/tags/... or refs/heads/freeze/..."
)
if expected_source_sha is None && expected_source_ref is None:
if expected_source_sha is None and expected_source_ref is None:
raise ContractError("frozen phase requires freeze.source_sha or freeze.source_ref")
identities = freeze.get("identities")
if not isinstance(identities, list) or not identities:
Expand Down
Loading