feat(ui): hide orchestrator/staging from the operator GUI - #19
Merged
Xander-git merged 2 commits intoMay 30, 2026
Merged
Conversation
Hide (not remove) the per-equipment `stage` sync mode and the staging-PC relay. Every equipment now syncs directly to the NAS (sync_mode="nas"); the staging backend stays dormant and tested for reversibility. No config schema change, no feature flag. UI surfaces gated: - Add-Equipment wizard: drop the sync-mode step (identity -> paths -> review); dormant _render_sync_mode_step kept as the reversibility hook. - Settings: rename "Orchestrator Mode" -> "Workstation" (section id kept, so the setup gate / routing are untouched); remove the staging-root input. - mount.py: remove the /staging route + footer clear-verified wiring and the helpers it orphaned (_build_staging_state, _bulk_clear_verified, _render_unavailable); keep the per-run tree context-menu actions (they serve nas runs) and reword their toasts off "staging". - main.py: remove the footer "Staging" segment + "Clear verified runs". Backend left intact and dormant: orchestrator/ (incl. the quiescence poller, the auto-sync engine for BOTH nas and stage runs), api/routers/staging.py, SyncMode.STAGE, orchestrator.staging_* fields. Tests: skip the staging-driven UI flows with reversible markers citing the spec; update wizard/settings/footer/persist tests; drop mount glue-fn tests for the removed helpers. Backend staging tests stay green, proving dormancy. Add a root CLAUDE.md documenting the hidden-but-present state so future work does not "fix" the missing UI or delete the shared poller. Spec: docs/superpowers/specs/2026-05-29-hide-orchestrator-staging-design.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removing the @ui.page("/staging") block left a single blank line before
the "Helpers" divider; ruff format wants two. No behavioural change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hide (not remove) the per-equipment
stagesync mode and the staging-PC relay (orchestrator). Every equipment now syncs directly to the NAS (sync_mode="nas"); the staging backend stays dormant and tested for reversibility. No config schema change, no feature flag. The app is not deployed, so there's no migration burden.Spec:
docs/superpowers/specs/2026-05-29-hide-orchestrator-staging-design.mdUI surfaces gated
identity → paths → review); the dormant_render_sync_mode_stepis kept as the reversibility hook."Orchestrator Mode" → "Workstation"(section id kept, so the setup gate / routing are untouched); remove the staging-root input./stagingroute + footer clear-verified wiring and the helpers it orphaned (_build_staging_state,_bulk_clear_verified,_render_unavailable); keep the per-run tree context-menu actions (they serve nas runs) and reword their toasts off "staging".Left intact & dormant (reversibility)
orchestrator/(incl. the quiescence poller — the auto-sync engine for both nas and stage runs),api/routers/staging.py,ui/pages/staging.py,SyncMode.STAGE, and theorchestrator.staging_*config fields. Re-enabling = restoring the four UI surfaces (spec §3.6).A new root
CLAUDE.mddocuments the hidden-but-present state so future work doesn't "fix" the missing UI or delete the shared poller.Tests
test_flow_09/18/21/23,test_staging_page) + individual skips for the sync-mode wizard step and the footer-callback test.Verification
ruff check src tests: cleantest_orchestrator_lifecycle)🤖 Generated with Claude Code