feat: mpv blur previews - #329
Merged
Merged
Conversation
vspipe passes blur.py its arguments with -a, which nothing in-process (like mpv's vapoursynth demuxer) can do. the generated .vpy passes them through blur/preview.py, which also loads the bundled plugins, stops blur.py's error handler from exiting the host process, and logs output so status lines can be read
removes the single frame render path (render_frame and its frame maths, ffmpeg_stops_early)
aiming half a frame early put the target below 0, and mpv takes a negative start as counting from the end
only shown while paused since the blur can't keep up with playback
frame-step's seek flag doesn't move forward on mpv 0.41, so it plays the frame with the audio muted instead
playback keys now only go to the shown screen's video, and not while typing
…wer one mpv gives a seek's target as the position straight away, so the preview fell back to the video's old frame until the seek landed
python stays loaded between preview scripts, so every reload added another copy
it was always the opposite of failed wherever it was read
a seek reports its target and then the frame it landed on, and stepping moves one source frame at a time, which usually land on the same blurred frame. seeking again cost another render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.