Hotfix: restore dropped 'raise' in get_components/get_links - #442
Merged
Merged
Conversation
When PRs #437 (lock idiom) and #440 (DB error propagation) were merged into rel-2.0.1, both edited get_components/get_links; the conflict resolution kept #440's explanatory comment but dropped its 'raise' statement. As a result rel-2.0.1 shipped the theme-2 unit test but not the code change, so the tests fail and DB/infra errors are still swallowed (returned as None -> read as 'nothing in use' -> double-allocation risk). Re-add 'raise' after logging in both methods. Restores the intended behavior; the unit suite (fabric_cf/actor/test/unit) passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rel-2.0.1 is currently broken: the unit tests added by #440 fail on it, because when #437 (lock idiom) and #440 (DB error propagation) were merged, both edited
get_components/get_linksand the conflict resolution kept #440's comment but dropped itsraisestatement.So
rel-2.0.1shipped the theme-2 test without the theme-2 fix: DB/infra errors are still swallowed and returned asNone, which the allocation logic reads as "nothing in use" (the double-allocation risk #440 set out to fix), and CI is red.Fix
Re-add
raiseafter logging in both methods (2 lines).Verification
python -m compileallpasses.fabric_cf/actor/test/unitpasses (11/11), including the previously-failingtest_actor_database_read_errors.Note
This also unblocks the pickle PR #441, whose CI was red only because it merges into this broken
rel-2.0.1. Merge this first; #441 will then go green on refresh.