Repository navigation
delete fbclock-bin - #584
Closed
leoleovich wants to merge 1 commit into
Closed
leoleovich wants to merge 1 commit into
leoleovich wants to merge 1 commit into
Conversation
Summary:
**Land after an fb-ptpcheck build containing D122125915 is on every host** (text default; 20260928-000432 and older are JSON-only without -j).
`ptpcheck fbclock` replaces fbclock-bin without a new RPM (the alternative to D121765502):
- D121818222: `-j/--json`; D122121244 + D122333820: collector and sudoers on `-j`; D122125915: text by default.
- Same C library: ptpcheck links `//time/fbclock:fbclock_c` and calls fbclock_init / fbclock_gettime[_utc] / fbclock_destroy, like fbclock-bin did.
This diff:
- `ptp/fbclock/BUCK`: fb-fbclock no longer installs `/usr/local/bin/fbclock-bin`; it is the sidecar and its unit only.
- deletes `time/cmd/fbclock-bin` (BUCK, Makefile, fbclock-bin.c).
- OSS (ShipIt to github.com/facebook/time): `.packit.yaml` post-upstream-clone now strips the Fedora spec's fbclock-bin build block and `%{_bindir}/fbclock-bin`, so Packit builds with or without the dist-git spec change and the two need no ordering. READMEs point to `ptpcheck fbclock`.
- `fbclock.h` is not touched: it feeds `fbclock_c` and the bindgen crate, so any edit to it runs CI for every fbclock consumer.
Follow-ups: Fedora dist-git drops fbclock-bin from the spec (committed locally, ab83798); once it lands, the two new sed expressions match nothing. configerator D122430206 drops `//time/cmd/fbclock-bin/...` from the fb-fbclock CI config plus detector runbook text. opsfiles `fbclock.rb` comment and `:metalos_preserve_rpm` belong to D121765502's chef diff.
Reviewed By: pmazzini
Differential Revision: D122430076
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@leoleovich has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122430076. |
Contributor
|
This pull request has been merged in e432cb7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Land after an fb-ptpcheck build containing D122125915 is on every host (text default; 20260928-000432 and older are JSON-only without -j).
ptpcheck fbclockreplaces fbclock-bin without a new RPM (the alternative to D121765502):-j/--json; D122121244 + D122333820: collector and sudoers on-j; D122125915: text by default.//time/fbclock:fbclock_cand calls fbclock_init / fbclock_gettime[_utc] / fbclock_destroy, like fbclock-bin did.This diff:
ptp/fbclock/BUCK: fb-fbclock no longer installs/usr/local/bin/fbclock-bin; it is the sidecar and its unit only.time/cmd/fbclock-bin(BUCK, Makefile, fbclock-bin.c)..packit.yamlpost-upstream-clone now strips the Fedora spec's fbclock-bin build block and%{_bindir}/fbclock-bin, so Packit builds with or without the dist-git spec change and the two need no ordering. READMEs point toptpcheck fbclock.fbclock.his not touched: it feedsfbclock_cand the bindgen crate, so any edit to it runs CI for every fbclock consumer.Follow-ups: Fedora dist-git drops fbclock-bin from the spec (committed locally, ab83798); once it lands, the two new sed expressions match nothing. configerator D122430206 drops
//time/cmd/fbclock-bin/...from the fb-fbclock CI config plus detector runbook text. opsfilesfbclock.rbcomment and:metalos_preserve_rpmbelong to D121765502's chef diff.Reviewed By: pmazzini
Differential Revision: D122430076