drop the fbclock-bin spec workaround - #585
Closed
leoleovich wants to merge 1 commit into
Closed
leoleovich wants to merge 1 commit into
leoleovich wants to merge 1 commit into
Conversation
Summary: D122430076 added two sed expressions to the post-upstream-clone action so Packit could build while the Fedora dist-git spec still built `cmd/fbclock-bin`. Fedora dist-git `main` dropped fbclock-bin (now at the 20260930 snapshot, 0 `fbclock-bin` lines), so both expressions match nothing. This removes them. Differential Revision: D122759707
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@leoleovich has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122759707. |
Contributor
|
This pull request has been merged in c71be27. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: D122430076 added two sed expressions to the post-upstream-clone action so Packit could build while the Fedora dist-git spec still built
cmd/fbclock-bin. Fedora dist-gitmaindropped fbclock-bin (now at the 20260930 snapshot, 0fbclock-binlines), so both expressions match nothing. This removes them.Differential Revision: D122759707