fix(desktop): stop sending temperature 0 to cloud LLMs - #6946
Closed
ComputelessComputer wants to merge 1 commit into
Closed
fix(desktop): stop sending temperature 0 to cloud LLMs#6946ComputelessComputer wants to merge 1 commit into
ComputelessComputer wants to merge 1 commit into
Conversation
Speaker attribution reintroduced temperature: 0 after #6667, which frontier models reject (HYPRNOTE2-2N35, HYPRNOTE2-2N38). Keep temperature 0 only for Apple Foundation Models, strip it from cloud provider requests, and drop remaining user-config LLM failures from Sentry. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
ComputelessComputer
deleted the
cursor/fix-sentry-temperature-rejections-1489
branch
August 20, 2026 06:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
High-priority Sentry alerts from today still show cloud LLM 400s for explicit
temperature: 0(HYPRNOTE2-2N35,HYPRNOTE2-2N38). #6667 stopped sending that default, then #6754 puttemperature: 0back on speaker attribution for Apple on-device models without gating it to Apple.temperature: 0only for Apple Foundation Modelstemperaturefrom all other cloud language-model requests so enhance/chat cannot regress the same wayTest plan
pnpm -F desktop exec tsc --noEmitpnpm -F desktop testpnpm exec oxlint --quiet --format=github apps/desktop/src/cargo test -p user-errorpnpm exec dprint fmt/ check on the changed non-Swift files