Fix Scalar::Watcher and Protocol::BitTorrent tooling - #932
Merged
Conversation
Implement Scalar::Watcher scalar magic in the shared runtime, including assignment, increment, cancellation, aggregate-slot destruction, and interpreter slot-identity parity. Add a Java Convert::Bencode_XS backend so Protocol::BitTorrent can load without native XS. Also expose Java XS initialization failures when require debugging is enabled, while retaining the normal compatibility error otherwise. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <223018245+openai-codex[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scalar::Watcherthrough shared runtime scalar mutation and destruction hooksConvert::Bencode_XSbackend used byProtocol::BitTorrentJPERL_REQUIRE_DEBUGValidation
make./jcpan -t Scalar::Watcher— 28 tests passed./jcpan -t Protocol::BitTorrent— 198 tests passed./jcpan -t Transmission::AttributeRole— 173 applicable tests passedModule::Readerwas not changed because its upstream suite also fails under system Perl 5.42. The standaloneConvert::Bencode_XSsuite has one platform-sensitive ordering failure under system Perl, while the completeProtocol::BitTorrentsuite passes with the Java backend.Generated with Codex