Clean up for public release: drop broken examples, fix stale docs - #13
Merged
Conversation
The [Unreleased] section only mentioned `export`; it now covers auth/setup/config, snapshot, the draft-first publish gate, agent skill distribution, and the plugin marketplace — the actual scope shipping in the first public release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Homepage/Repository/Issues pointing at finolabs/threads-cli — standard metadata for the wheel and any future package index listing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Security/OSS-readiness audit follow-ups before flipping public: - Remove examples/ — the scripts referenced a vendored examples/threads/cli/ layout and requirements.txt that no longer exist (src/ layout), were wired into nothing (not in README/docs/CI), and would fail for any user. One script also exfiltrated post text to quickchart.io. The canonical workflow lives in the `threads draft` commands. Drops the now-dead ruff examples/** ignore rule. - Remove BUILD-PLAN.md — internal planning doc, not meant for a public repo. - .env.example: redirect URI was http://localhost:8080 (rejected by Threads, wrong port); fix to https://localhost:8473 and refresh stale auth-local notes. - SECURITY.md: replace the address-less "email the maintainer" with GitHub private vulnerability reporting; add credential-handling scope notes. Audit found no secret/PII leakage and no injection vectors in shipped code. 87 tests pass, ruff clean, wheel still bundles the skill. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final cleanup before flipping the repo public, driven by a security + OSS-readiness audit.
Audit verdict
No secret/credential leakage, no PII, no injection vectors in shipped code (
src/). Token redaction,0600.envperms, and the skills-install path hardening are all correct and test-covered.Changes
examples/(HIGH). Scripts referenced a vendoredexamples/threads/cli/+requirements.txtthat don't exist in thesrc/layout — broken for any user, wired into nothing (not in README/docs/CI).dashboard.pyalso sent post text to quickchart.io. The canonical workflow is thethreads draftcommands. Also drops the now-deadexamples/**ruff ignore rule.BUILD-PLAN.md— internal planning doc, not for a public repo (recoverable from history)..env.example(MEDIUM) — redirect URI washttp://localhost:8080(Threads rejects http + wrong port) →https://localhost:8473; refresh staleauth-localnotes.SECURITY.md— address-less "email the maintainer" → GitHub private vulnerability reporting; add credential-handling scope notes.[project.urls]metadata.Known follow-up (non-blocking, LOW)
OAuth flow has no
state/CSRF param. Risk is low for a manual copy-paste flow with no automated listener; deliberately not changing the auth path at publish time.Verification
87 tests pass · ruff check + format clean · wheel builds and still bundles the skill · final secret/PII grep clean.
🤖 Generated with Claude Code