fix(ci)!: refresh security and build workflows - #59
Conversation
Signed-off-by: el kampu <11272320+elkampu@users.noreply.github.com>
|
|
Use active Node LTS releases, avoid persisting write-scoped checkout credentials, and keep CVE scans synchronized with dependency-control files. BREAKING CHANGE: The JavaScript client now requires Node.js 22 or newer. Signed-off-by: el kampu <11272320+elkampu@users.noreply.github.com>
|
Hi @kriswest — I have pushed a follow-up addressing the review findings: the JavaScript client now declares Node.js 22+ and CI covers the supported Node.js 22/24 LTS lines, the Doxygen workflow no longer persists its write-scoped checkout credential, the .NET vulnerability scan watches dependency-control files, and the stale allow-list path filter is removed. The runtime compatibility change is called out explicitly in the PR description and commit metadata. I reran EasyCLA is green. GitHub currently shows the five fork-triggered workflows for the new head as awaiting approval, and CodeQL is disabled due to inactivity. When convenient, could you approve those workflow runs, re-enable CodeQL, and review the PR? I can update the branch again if GitHub needs a new synchronization event after CodeQL is enabled. Thanks! |
kriswest
left a comment
There was a problem hiding this comment.
HI @elkampu, thanks for taking this on. It looks like the build is failing on the package-lock.json being out of sync with the package.json file. Could you run an npm install locally and check-in the result? That should resolve the issue
Summary
npm audit, add scheduled/manual dependency scans, and align the .NET scan with FINOS'scve-scanning.ymlconvention@microsoft/signalrto 10.0.11 so the JavaScript client's production dependency audit is clean, then remove the obsolete advisory allow-listCompatibility
This changes the JavaScript client's declared minimum runtime from Node.js 10 to Node.js 22. Node.js 10 has long been end-of-life, Node.js 20 reached end-of-life in March 2026, and the updated CI matrix now covers the supported Node.js 22 and 24 LTS releases. The follow-up commit carries a
BREAKING CHANGEfooter so semantic-release does not present the dropped runtime support as a patch-only change.Validation
actionlint .github/workflows/*.ymlnpm ci,npm run lint,npm run buildnpm ci --omit dev,npm audit --omit dev --audit-level high(0 vulnerabilities)node-license-validatorwith the repository's existing allow-list (passed)git diff --checkThe JavaScript project currently has no runnable tests; Jest exits with
No tests found. Its legacy TSDX development toolchain also still has audit findings, while the shipped production dependency tree is clean. Those development-tooling findings are intentionally kept separate from this focused workflow/security update and are tracked in #60.Closes #58