fix(breadcrumbs): keep the execution domain in links - #939
Merged
Sovietaced merged 1 commit intoAug 24, 2026
Merged
Conversation
…cution's domain getExecutionSpecProjectDomain tests breadcrumb.projectId against the execution's domain when deciding which domain to use. The project branch above it compares projectId to project, so the domain branch is comparing the wrong field. When a project happens to be named after a domain, the comparison succeeds and the breadcrumb resolves to whatever domain the user is currently browsing rather than the execution's own. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
changed the title
8 tasks
|
Congrats on merging your first pull request! 🎉 |
Collaborator
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
A breadcrumb can link to the domain currently being browsed instead of the execution's
own domain.
Before this change, browsing project
productionin domainstagingcan send anexecution from domain
productionback tostaging. After this change, the linkalways keeps the execution's domain.
Type
Are all requirements met?
Complete description
Compare the selected domain, rather than the selected project, with the execution
domain.
Manual check:
productionin domainstaging.production.Before this change, the link returns to domain
staging. With this change, it stays indomain
production.The focused breadcrumb test receives
staginginstead ofproductionon master andpasses on this branch.
The same one-line correction is present in the broader breadcrumb PR:
#921.
Tracking Issue
N/A
Follow-up issue
N/A