Skip to content

feat: harmonize deployment to use dockerfiles and bump to google-24-full and python314 - #230

Open
nikbpetrov wants to merge 2 commits into
forecastingresearch:mainfrom
nikbpetrov:makefile-cleanup
Open

feat: harmonize deployment to use dockerfiles and bump to google-24-full and python314#230
nikbpetrov wants to merge 2 commits into
forecastingresearch:mainfrom
nikbpetrov:makefile-cleanup

Conversation

@nikbpetrov

@nikbpetrov nikbpetrov commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Resolves #222

Tested together with #231

@houtanb

houtanb commented Aug 25, 2026

Copy link
Copy Markdown
Member

@nikbpetrov the above is a big improvement. Could you make these changes in this commit as well:

  1. Add deploy_config.mk (or other name) and consolidating the .gcloudignore and Dockerfile rules there and simply import that everywhere to consolidate the cookie-cutter build rules
  2. Add .python-version to the root dir and:
    1. derive PYTHON_RUNTIME from that in the Makefile
    2. use it to set the python version for thein the CI: .github/workflows/makefile.yml. Claude says you get this for free if you move to actions/setup-python@v7

@nikbpetrov

Copy link
Copy Markdown
Collaborator Author

Done - very clean indeed.

2ii verified here with python-version-file arg optional.

set .DEFAULT_GOAL := lint in Makefile (root one) just becasuse we currently have include *.mk which defines a bunch of vars in there - it's just comestic noise but without that default goal the first included command would be executed on an empty make call

@houtanb

houtanb commented Aug 26, 2026

Copy link
Copy Markdown
Member

Great! One last thing to test out: edit deploy_config.mk to be like:

DOCKERFILE_TEMPLATE ?= $(ROOT_DIR)src/helpers/Dockerfile.template
Dockerfile: $(DOCKERFILE_TEMPLATE)

then in move src/nightly_update_workflow/compress_buckets/Dockerfile to src/nightly_update_workflow/compress_buckets/Dockerfile.template and then in the Makefile in that dir do:

DOCKERFILE_TEMPLATE = Dockerfile.template
include $(ROOT_DIR)deploy_config.mk

To be tested, but I think that would let us get rid of the hard-coded serverless runtiime and python version.

If you agree the above is better, could you make the fix and also do a complete test run to make sure it all goes through? There might be a problem with Kalshi at the moment as it broke last night, so might need to skip that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: makefile cleanup

2 participants