feat: harmonize deployment to use dockerfiles and bump to google-24-full and python314 - #230
feat: harmonize deployment to use dockerfiles and bump to google-24-full and python314#230nikbpetrov wants to merge 2 commits into
google-24-full and python314#230Conversation
34974b7 to
5dd9a1d
Compare
5dd9a1d to
ee533d3
Compare
ee533d3 to
a1e2d82
Compare
|
@nikbpetrov the above is a big improvement. Could you make these changes in this commit as well:
|
a1e2d82 to
49c16ef
Compare
|
Done - very clean indeed. 2ii verified here with set |
|
Great! One last thing to test out: edit DOCKERFILE_TEMPLATE ?= $(ROOT_DIR)src/helpers/Dockerfile.template
Dockerfile: $(DOCKERFILE_TEMPLATE)then in move DOCKERFILE_TEMPLATE = Dockerfile.template
include $(ROOT_DIR)deploy_config.mkTo be tested, but I think that would let us get rid of the hard-coded serverless runtiime and python version. If you agree the above is better, could you make the fix and also do a complete test run to make sure it all goes through? There might be a problem with Kalshi at the moment as it broke last night, so might need to skip that. |
49c16ef to
c537528
Compare
c537528 to
2aa1e37
Compare
Resolves #222
Tested together with #231