Skip to content

fix: clean up workspace directories on implementation retry failure - #285

Open
richardmilles wants to merge 1 commit into
forge-sdlc:mainfrom
richardmilles:fix/issue-191
Open

fix: clean up workspace directories on implementation retry failure#285
richardmilles wants to merge 1 commit into
forge-sdlc:mainfrom
richardmilles:fix/issue-191

Conversation

@richardmilles

Copy link
Copy Markdown

Remove leftover /tmp workspace directories when the implementation node retries after persistent failure.
Fixes #191

Remove leftover /tmp workspace directories when the implementation node retries after persistent failure.

@eshulman2 eshulman2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orphan-target cleanup is still required on current main, but this branch is not safe to merge as-is. In implement_task, every prepare_workspace() exception now sets workspace_path to None. That includes a pull/rebase failure for an existing workspace, where prepare_workspace() intentionally preserves the directory because it may contain the only unpushed commit. Clearing the state reference makes the next attempt recreate elsewhere and can orphan or effectively lose that work. Please keep the existing workspace_path when the recorded workspace still exists, and add a regression test for an existing-workspace sync failure. The node-level retry cap/backoff also duplicates the graph-level configurable retry cap; the narrowly required part for #191 is cleanup of the empty target allocated when recreation fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Implementation node retry loop fills /tmp with workspace directories on persistent failure

2 participants