Skip to content

fix: preserve shared skill mounts across concurrent sandboxes - #321

Merged
eshulman2 merged 1 commit into
mainfrom
fix/shared-skill-selinux-label
Aug 27, 2026
Merged

fix: preserve shared skill mounts across concurrent sandboxes#321
eshulman2 merged 1 commit into
mainfrom
fix/shared-skill-selinux-label

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • mount shared skill directories with the shared SELinux z label
  • retain read-only access while preventing concurrent containers from relabeling each other
  • add a regression test for the mount mode

Cause

Skill directories used ro,Z, which assigns a private SELinux label. Concurrent sandbox starts can relabel the same host directory and cause an already-running container to fail with PermissionError while reading review.md.

Verification

  • pytest -q tests/unit/sandbox/test_runner_mounts.py tests/unit/sandbox/test_podman_driver.py
  • ruff check src/forge/sandbox/runner.py tests/unit/sandbox/test_runner_mounts.py
  • git diff --check

@eshulman2
eshulman2 merged commit 0ae5063 into main Aug 27, 2026
8 checks passed
@eshulman2
eshulman2 deleted the fix/shared-skill-selinux-label branch August 27, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant