fix(windows): show conversation cloud-list failures when only local rows exist - #56
Draft
formed2forge wants to merge 1 commit into
Draft
fix(windows): show conversation cloud-list failures when only local rows exist#56formed2forge wants to merge 1 commit into
formed2forge wants to merge 1 commit into
Conversation
…al rows GET /v1/conversations is account-wide, not device-scoped. A failed or non-array response plus a few local Windows recordings used to look like "this install has no other devices' history" because the banner was `error && rows.length === 0`. Show the cloud error whenever no cloud row is on screen. Treat a non-list body as a fetch failure. Fall the renderer API base back to https://api.omi.me (and copy .env.example on `pnpm dev`) so a missing Vite env does not hit the local origin. Verification: pnpm exec vitest run src/renderer/src/lib/conversations/filtering.test.ts — 27 passed. Failure-Class: FC-denial-rendered-as-empty-success Co-authored-by: 97rh699b7t <97rh699b7t@privaterelay.appleid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Windows install that can record locally but cannot pull
GET /v1/conversationslooked like it had no phone/Linux history. The Conversations page only rendered the cloud error whenrows.length === 0, so any local recording hid a failed or non-array cloud response.The backend list is account-wide (not device-scoped). A 200 HTML/object from the Vite origin (missing
VITE_OMI_API_BASE) was also treated as[].What
Cloud conversations: …whenever the fetch failed and no cloud row is on screen. A failed revalidation over an already-visible cloud list stays quiet.omiApifalls back tohttps://api.omi.mewhen the Vite env is blank (main process already did this).pnpm devrunsensure-env.mjsso a checkout without.envgets the public production defaults.Folded into
windows-all-fixesMerge
2a71b814d5. GUI:git fetch origin && git checkout windows-all-fixes && git reset --hard origin/windows-all-fixes. Do not merge this to forkmain.Verification
On the Windows box after the WAF reset: open Conversations. If the cloud pull is still failing, a banner should appear above the local recordings. DevTools → Network should show
GET https://api.omi.me/v1/conversationswith a JSON array andAuthorization: Bearer …. Settings → Account email must match Linux/phone.Failure-Class: FC-denial-rendered-as-empty-success