Feature/wip filtering relationship - #35
Merged
gr0uch merged 7 commits intoJun 23, 2020
Merged
Conversation
Notes ----- I am unsure what field of options may be used. The options.query already seemed to be used, so started looking for another field. As I understand it, Adapter.find leaves the possibility of extra fields on the options object unspecified. Therefore, I added the fuzzyMatch field.
As a try out, I extend the fuzzy matching on relationship - Abstracted away relation filter parsing - Change filter[author.posts] to filter[author:posts]. Ember (considered baseline use case) doesn't like parsing the former format in its queryParams parser.
gr0uch
requested changes
May 25, 2020
gr0uch
left a comment
gr0uch
left a comment
Member
There was a problem hiding this comment.
Code looks fine. Can you run the tests though?
pretty sure this will fail lint test
See PR discussion remark fortunejs#35 (comment)
…eature/wip-filtering-relationship
Contributor
Author
|
Think it should pass linting tests too now |
gr0uch
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a try-out, I extend the fuzzy matching on relationship. Here the implementation in fortune-postgres.
Please refer to fortunejs/fortune-json-api#73 for API discussions.