refactor(exclude): own EXCLUDE_FILENAME_BINARY in binary scanner - #216
Conversation
Keep fosslight_bin* excludes local so util shared exclude stays scanner-agnostic.
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe binary scanner now excludes its generated output files, ChangesBinary exclusion
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The binary scanner now excludes its own fosslight_bin output filenames while preserving scanner-agnostic shared exclusions. No merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a757830 to
203c4c2
Compare
Need exclude_filenames for EXCLUDE_FILENAME_BINARY.
Keep fosslight_bin* excludes local so util shared exclude stays
scanner-agnostic.
Summary by CodeRabbit