Skip to content

refactor(exclude): own EXCLUDE_FILENAME_BINARY in binary scanner - #216

Merged
soimkim merged 2 commits into
mainfrom
separate_exclude
Sep 7, 2026
Merged

refactor(exclude): own EXCLUDE_FILENAME_BINARY in binary scanner#216
soimkim merged 2 commits into
mainfrom
separate_exclude

Conversation

@soimkim

@soimkim soimkim commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Keep fosslight_bin* excludes local so util shared exclude stays
scanner-agnostic.

Summary by CodeRabbit

  • Bug Fixes
    • Prevented the binary scanner from re-analyzing its own generated executable files.
    • Improved file exclusion handling in both standard and simplified scanning modes.

Keep fosslight_bin* excludes local so util shared exclude stays
scanner-agnostic.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 535a9684-8a18-45e6-bdf5-a4ea1e806492

📥 Commits

Reviewing files that changed from the base of the PR and between 203c4c2 and 877ff7a.

📒 Files selected for processing (1)
  • pyproject.toml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: b832fd69-c733-464d-b6c8-80bed782db3a

📥 Commits

Reviewing files that changed from the base of the PR and between 55c6217 and 203c4c2.

📒 Files selected for processing (2)
  • src/fosslight_binary/_exclude.py
  • src/fosslight_binary/binary_analysis.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The binary scanner now excludes its generated output files, fosslight_bin and fosslight_bin.exe, during file listing and excluded-path collection.

Changes

Binary exclusion

Layer / File(s) Summary
Define binary filename exclusions
src/fosslight_binary/_exclude.py
Adds EXCLUDE_FILENAME_BINARY and is_excluded_binary_filename for matching scanner output filenames.
Apply exclusions during scanning
src/fosslight_binary/binary_analysis.py
Skips matching files during listing and passes the binary exclusion set to simple-mode and normal-mode excluded-path collection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 203c4

The binary scanner now excludes its own fosslight_bin output filenames while preserving scanner-agnostic shared exclusions. No merge-blocking risk is identified.

Suggested reviewers: bjk7119

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving EXCLUDE_FILENAME_BINARY ownership into the binary scanner.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch separate_exclude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Need exclude_filenames for EXCLUDE_FILENAME_BINARY.
@soimkim soimkim self-assigned this Sep 7, 2026
@soimkim soimkim added the bug fix [PR] Fix the bug label Sep 7, 2026
@soimkim
soimkim merged commit 7d0e2a8 into main Sep 7, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant