api: fix two racey tests in the UI API test suite - #255
Merged
Conversation
TestApiRolloutDaemon started the watchdog daemon before calling CreateRollout, so the daemon's 20ms tick could commit the rollout before the pre-commit assertions ran. Move daemons.Start() to after those assertions. TestApiUpdateTail used exact equality to assert the body of an SSE stream that also receives keepalives every 50ms. A third keepalive could accumulate between requireBody returning (after 2 keepalives) and d1.ProcessEvents firing, making the subsequent exact-equality check unsatisfiable. Replace with strings.Contains so the check is immune to the number of leading keepalives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Member
Author
|
I keep hitting this issue when tests are run here: I let Claude debug and fix it based on the logs from Github run. |
doanac
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestApiRolloutDaemon started the watchdog daemon before calling
CreateRollout, so the daemon's 20ms tick could commit the rollout
before the pre-commit assertions ran. Move daemons.Start() to after
those assertions.
TestApiUpdateTail used exact equality to assert the body of an SSE
stream that also receives keepalives every 50ms. A third keepalive
could accumulate between requireBody returning (after 2 keepalives)
and d1.ProcessEvents firing, making the subsequent exact-equality
check unsatisfiable. Replace with strings.Contains so the check is
immune to the number of leading keepalives.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: Milo Casagrande mcasagra@qti.qualcomm.com