Skip to content

Improve how healthchecks are done - #257

Merged
doanac merged 3 commits into
mainfrom
gw-healthz
Sep 7, 2026
Merged

Improve how healthchecks are done#257
doanac merged 3 commits into
mainfrom
gw-healthz

Conversation

@doanac

@doanac doanac commented Sep 2, 2026

Copy link
Copy Markdown
Member

When you start to run our server in AWS and GCP, you'll quickly get swamped with TLS handshake error messages and /favicon page hits. This PR introduces a /healthz endpoint that logs 1 out of every 10 checks to help prevent being swamped by noise.

@doanac
doanac requested a review from vkhoroz September 2, 2026 20:40

@vkhoroz vkhoroz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread server/echo.go Outdated
Comment thread server/echo.go Outdated
Andy Doan added 3 commits September 7, 2026 10:11
This also only logs a sampling of healthz checks to prevent swamping our
logs in things like GCP with load-balancer health checks

Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
Build on the /healthz logic of the previous commit to make logs cleaner
for our UI code as well.

Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
@doanac
doanac merged commit 870cfab into main Sep 7, 2026
17 checks passed
@doanac
doanac deleted the gw-healthz branch September 7, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants