feat: regenerate API client from OpenAPI spec - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated regeneration via OpenAPI Generator (java/native) from
docs/v3/openapi3.yamlon frain-dev/convoy main. Hand-written webhook verify (src/main/java/com/getconvoy/webhook/) is untouched by the sync script.Note
Medium Risk
Public method signatures for listing and batch-replaying events change, so downstream callers can fail to compile. Behavior is still generated client plumbing, not auth or data-store logic.
Overview
Regenerates the Java client so event list, batch replay, and count-affected calls can send a dedicated
bodyquery param (URL-encoded JSON payload match, ANDed withquery).batchReplayEvents,countAffectedEvents, andgetEventsPagednow take an extra optionalbodyargument afterprojectIDand send it as a query string.querydocs now describe prefix/metadata matching vs payload containment.searchPolicyonDatastoreProjectConfiggets a longer Javadoc only.Breaking: existing positional callers of those three methods must insert
body(ornull).Reviewed by Cursor Bugbot for commit 10d0c35. Bugbot is set up for automated code reviews on this repo. Configure here.