Skip to content

feat: add gap handlers for flex and grid containers - #792

Open
SmrutiSawant wants to merge 2 commits into
frappe:developfrom
SmrutiSawant:gaps
Open

feat: add gap handlers for flex and grid containers#792
SmrutiSawant wants to merge 2 commits into
frappe:developfrom
SmrutiSawant:gaps

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Contributor

Add on-canvas gap handles

Flex and grid containers could only have gap changed from the Layout panel.
Padding and margin already have draggable on-canvas handles; this adds the
equivalent for gap.

Demo

Recording.2026-08-31.130737.mp4

@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (2): Last reviewed commit: "fix: gap handles land on wrong seams whe..." | Re-trigger Greptile

Comment thread frontend/src/components/GapHandler.vue
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (12c787a) to head (a22330b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #792   +/-   ##
========================================
  Coverage    66.06%   66.06%           
========================================
  Files           93       93           
  Lines        10386    10386           
========================================
  Hits          6862     6862           
  Misses        3524     3524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant