fix: close block context menu when a keyboard command runs - #795
Open
SmrutiSawant wants to merge 1 commit into
Open
fix: close block context menu when a keyboard command runs#795SmrutiSawant wants to merge 1 commit into
SmrutiSawant wants to merge 1 commit into
Conversation
Contributor
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The wrapper preserves the commands’ zero-argument void contract, and context-menu dismissal only changes menu visibility before executing each action. Reviews (1): Last reviewed commit: "fix: close block context menu when a key..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #795 +/- ##
========================================
Coverage 66.06% 66.06%
========================================
Files 93 93
Lines 10386 10386
========================================
Hits 6862 6862
Misses 3524 3524 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Select a block, right-click to open the context menu, then press
?.The Keyboard Shortcuts modal opens but the context menu stays on
screen, floating on top of the modal.
before.mp4
Fix
commandShortcuts()now wraps each command's action to dismiss theblock context menu before running it
now.mp4