Skip to content

fix: close block context menu when a keyboard command runs - #795

Open
SmrutiSawant wants to merge 1 commit into
frappe:developfrom
SmrutiSawant:fix
Open

fix: close block context menu when a keyboard command runs#795
SmrutiSawant wants to merge 1 commit into
frappe:developfrom
SmrutiSawant:fix

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Contributor

Problem

Select a block, right-click to open the context menu, then press ?.
The Keyboard Shortcuts modal opens but the context menu stays on
screen, floating on top of the modal.

before.mp4

Fix

commandShortcuts() now wraps each command's action to dismiss the
block context menu before running it

now.mp4

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The wrapper preserves the commands’ zero-argument void contract, and context-menu dismissal only changes menu visibility before executing each action.

Reviews (1): Last reviewed commit: "fix: close block context menu when a key..." | Re-trigger Greptile

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (12c787a) to head (47c769e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #795   +/-   ##
========================================
  Coverage    66.06%   66.06%           
========================================
  Files           93       93           
  Lines        10386    10386           
========================================
  Hits          6862     6862           
  Misses        3524     3524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant