fix: two keyboard shortcut bugs - #796
Open
SmrutiSawant wants to merge 2 commits into
Open
Conversation
Contributor
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The storage lifetime now matches the application module lifetime, while the removed shortcut only wrote an otherwise unread field. Reviews (1): Last reviewed commit: "fix: remove dead Ctrl+Shift+L highlight-..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #796 +/- ##
========================================
Coverage 66.06% 66.06%
========================================
Files 93 93
Lines 10386 10386
========================================
Hits 6862 6862
Misses 3524 3524 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stravo1
approved these changes
Sep 4, 2026
| const pageStore = usePageStore(); | ||
| const canvasStore = useCanvasStore(); | ||
|
|
||
| // module scope, not inside the command action: useStorage subscribes to storage |
Member
There was a problem hiding this comment.
we can make the comment more concise.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ctrl+Shift+C leaked a listener per press copy-block-styles called useStorage() inside action(). VueUse attaches cleanup to Vue's active effect scope; a keypress handler has none, so the cleanup was silently dropped. Now hoisted to module scope
Ctrl+Shift+L was bound twice
The "Highlight Blocks with Client Scripts" hold binding collided with the Layers tab (highlightBlocksWithClientScripts was written, never read). Removed the binding and the dead store field.