Skip to content

fix: match font dropdown width to its input field - #797

Open
SmrutiSawant wants to merge 2 commits into
frappe:developfrom
SmrutiSawant:fix-font-dropdown
Open

fix: match font dropdown width to its input field#797
SmrutiSawant wants to merge 2 commits into
frappe:developfrom
SmrutiSawant:fix-font-dropdown

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Contributor

Problem
The font dropdown was pinned to a 240px minimum width, unlike other property dropdowns.
image

Solution
Remove the fixed minimum width and use a hover marquee to reveal truncated labels.
When enabled, long option labels scroll horizontally into view on hover, preserving access to the full name without increasing the dropdown width.
Recording 2026-09-04 154814

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge, though the existing non-blocking touch-accessibility concern remains.

The keyboard path was added, but touch users still cannot trigger the full-label reveal, so the previous finding is only partially fixed.

Files Needing Attention: frontend/src/components/MiddleTruncate.vue

Reviews (2): Last reviewed commit: "fix: reveal truncated option labels on k..." | Re-trigger Greptile

Comment on lines +8 to +9
@mouseenter="marquee && startScroll()"
@mouseleave="marquee && stopScroll()">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Hover-Only Label Reveal
The full-label reveal only responds to mouse hover. Keyboard-highlighted and touch-operated font options cannot trigger the marquee, so truncated names remain unreadable; add an equivalent keyboard and touch interaction.

Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/components/MiddleTruncate.vue
Line: 8-9

Comment:
**Hover-Only Label Reveal**
The full-label reveal only responds to mouse hover. Keyboard-highlighted and touch-operated font options cannot trigger the marquee, so truncated names remain unreadable; add an equivalent keyboard and touch interaction.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (b6bd11d) to head (c28178f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #797   +/-   ##
========================================
  Coverage    66.06%   66.06%           
========================================
  Files           93       93           
  Lines        10386    10386           
========================================
  Hits          6862     6862           
  Misses        3524     3524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant