Skip to content

[Dependencies] Updating FunFair.Test (Test Infrastructure) to 6.4.0.2617 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnyw4l3n13 merged 2 commits into from
Aug 21, 2026
Merged

[Dependencies] Updating FunFair.Test (Test Infrastructure) to 6.4.0.2617 #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d377b8
[Dependencies] Updating FunFair.Test (Test Infrastructure) to 6.4.0.2617
credfeto Aug 20, 2026
00c232d
Fix CS0433 ambiguous xunit type conflict from FunFair.Test.Common 6.4…
dnyw4l3n13 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
- Pass ILogger to HealthCheckClient.ExecuteAsync to match new API in Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928
- Made DiscordChannelAdapter testable by accepting ITextChannel instead of the sealed SocketTextChannel, and added unit tests
- Guard against IndexOutOfRangeException when Branches list is empty in GithubStatusNotificationHandler
- Fixed CS0433 ambiguous xunit type conflict in test projects caused by FunFair.Test.Common now depending on the AOT-flavoured xunit v3 packages, by switching test projects to the matching xunit.v3.aot.mtp-v2 runner package
### Changed
- Dependencies - Updated NSubstitute.Analyzers.CSharp to 1.0.17
- Switched to use minimal APIs
Expand Down Expand Up @@ -60,7 +61,6 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
- Dependencies - Updated NSubstitute to 6.2.0
- SDK - Updated DotNet SDK to 10.0.400
- Dependencies - Updated Microsoft.Extensions to 10.0.11
- Dependencies - Updated FunFair.Test to 6.3.8.2585
- Dependencies - Updated xunit.analyzers to 2.0.0
- Dependencies - Updated xunit.v3 to 4.0.0
- Dependencies - Updated Microsoft.NET.Test.Sdk to 18.9.0
Expand All @@ -72,6 +72,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
- Dependencies - Updated Meziantou.Analyzer to 3.0.173
- Dependencies - Updated Credfeto.Docker.HealthCheck.Http.Client to 0.0.77.1109
- Dependencies - Updated FunFair.Test.Source.Generator to 6.4.0.2617
- Dependencies - Updated FunFair.Test to 6.4.0.2617
### Deprecated
### Removed
### Deployment Changes
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.CloudFormation.Tests/BuildBot.CloudFormation.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
<ProjectReference Include="..\BuildBot.CloudFormation\BuildBot.CloudFormation.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.Discord.Tests/BuildBot.Discord.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@
<ProjectReference Include="..\BuildBot.Discord\BuildBot.Discord.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
2 changes: 1 addition & 1 deletion src/BuildBot.Discord.Tests/Services/BotServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ await bot.Received(1)

[Theory]
[MemberData(nameof(NullConstructorArguments))]
public void Constructor_ThrowsArgumentNullException_WhenParameterIsNull(
public static void Constructor_ThrowsArgumentNullException_WhenParameterIsNull(
int nullParameterIndex,
string expectedParamName
)
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.GitHub.Tests/BuildBot.GitHub.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@
<ProjectReference Include="..\BuildBot.GitHub\BuildBot.GitHub.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.GitHub.Tests/Helpers/MainBranchDetectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public sealed class MainBranchDetectorTests : TestBase
[Theory]
[InlineData("main")]
[InlineData("master")]
public void ShouldBeMainBranch(string branch)
public static void ShouldBeMainBranch(string branch)
{
Assert.True(MainBranchDetector.IsRepoMainBranch(branch), userMessage: "Should be main branch");
}
Expand All @@ -19,7 +19,7 @@ public void ShouldBeMainBranch(string branch)
[InlineData("feature/main")]
[InlineData("fix/master")]
[InlineData("mainly")]
public void ShouldNotMainBranch(string branch)
public static void ShouldNotMainBranch(string branch)
{
Assert.False(MainBranchDetector.IsRepoMainBranch(branch), userMessage: "Should not be main branch");
}
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.GitHub.Tests/Helpers/PackageUpdateDetectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public sealed class PackageUpdateDetectorTests : TestBase
[InlineData("[FF-1429] - Updated something else")]
[InlineData("Dependencies - Updated package")]
[InlineData("[Dependencies] - Updated something else")]
public void ShouldBeConsideredAPackageUpdate(string commitMessage)
public static void ShouldBeConsideredAPackageUpdate(string commitMessage)
{
Assert.True(PackageUpdateDetector.IsPackageUpdate(commitMessage), userMessage: "Should be a package update");
}
Expand All @@ -24,7 +24,7 @@ public void ShouldBeConsideredAPackageUpdate(string commitMessage)
[InlineData("Validating Dependencies")]
[InlineData("Validating Dependencies of packages")]
[InlineData("Identifying [Dependencies] too")]
public void ShouldNotBeConsideredAPackageUpdate(string commitMessage)
public static void ShouldNotBeConsideredAPackageUpdate(string commitMessage)
{
Assert.False(
PackageUpdateDetector.IsPackageUpdate(commitMessage),
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.Health.Tests/BuildBot.Health.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
<ProjectReference Include="..\BuildBot.Health\BuildBot.Health.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.Json.Tests/BuildBot.Json.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
<ProjectReference Include="..\BuildBot.Json\BuildBot.Json.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.ServiceModel.Tests/BuildBot.ServiceModel.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
<ProjectReference Include="..\BuildBot.ServiceModel\BuildBot.ServiceModel.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
2 changes: 1 addition & 1 deletion src/BuildBot.ServiceModel.Tests/ComponentStatus/ServiceStatusTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public void NamePropertyMatchesConstructorArgument()
[Theory]
[InlineData(true)]
[InlineData(false)]
public void OkPropertyMatchesConstructorArgument(bool ok)
public static void OkPropertyMatchesConstructorArgument(bool ok)
{
ServiceStatus status = new(Name: "database", Ok: ok);

Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.Tests/BuildBot.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@
<ProjectReference Include="..\BuildBot.Json\BuildBot.Json.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
4 changes: 2 additions & 2 deletions src/BuildBot.Watchtower.Tests/BuildBot.Watchtower.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
<ProjectReference Include="..\BuildBot.Watchtower\BuildBot.Watchtower.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FunFair.Test.Common" Version="6.3.8.2585" />
<PackageReference Include="FunFair.Test.Common" Version="6.4.0.2617" />
<PackageReference Include="NSubstitute" Version="6.2.0" />
<PackageReference Include="xunit.v3.mtp-v2" Version="4.0.0" />
<PackageReference Include="xunit.v3.aot.mtp-v2" Version="4.0.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
Loading