Conform HTTPMethod to Sendable - #116
Open
radimvaculik wants to merge 1 commit into
Open
Conversation
jmarek41
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FTAPIKit 2.0 advertises full Swift 6 concurrency safety, and the async API (
URLServer.call(endpoint:)) hands the endpoint to a@concurrentcontext.Endpoint.methodis a stored property on most endpoints, so as soon as a consumer marks its endpoint typesSendable— which the async API effectively requires — the compiler reports:The only workaround on the consumer side is a retroactive conformance:
which is awkward and would break the moment FTAPIKit declares the conformance itself.
Change
HTTPMethodis a plainString-backed enum with no associated values, so it is triviallySendable. This just states it.Adding a conformance is additive — no existing code breaks.
Not included
Two related gaps I deliberately left out because they need a design decision rather than a one-liner:
MultipartBodyPartstores anInputStream, so it is not safelySendableas-is. Consumers ofMultipartEndpointcurrently have to fall back to@unchecked Sendableon their endpoint types.Endpoint: Sendablewould be the complete fix, since the async API already sends endpoints across isolation domains, but it is source-breaking for existing conformances.Happy to follow up on either if you have a preferred direction.
Verification
swift buildpasses. The test suite could not be run to completion here —ErrorHandlingTestsandEndpointTypeTestshithttpbin.orgover the network and time out in this environment; the failures are unrelated to this change.