Read the webhook caller address the way the instance is configured - #39
Merged
Conversation
The webhook checks that a notification comes from HelloAsso by comparing the caller address to a known one. It asked History for that address without handing over the preferences, so the X-Forwarded-For lookup was skipped: an instance behind a reverse proxy compared its own proxy address to HelloAsso's and answered 403, dropping the payment. Galette 1.3 moved that setting out of behavior.inc.php into pref_x_forwarded_for_index, which findUserIPAddress() now expects to be given. The controller has the preferences injected, so it passes them.
gagnieray
approved these changes
Aug 31, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webhook checks that a notification comes from HelloAsso by comparing the caller address to a known one. It asked History for that address without handing over the preferences, so the X-Forwarded-For lookup was skipped: an instance behind a reverse proxy compared its own proxy address to HelloAsso's and answered 403, dropping the payment.
Galette 1.3 moved that setting out of behavior.inc.php into pref_x_forwarded_for_index, which findUserIPAddress() now expects to be given. The controller has the preferences injected, so it passes them.