Release script fixes - #64
Open
trasher wants to merge 1 commit into
Open
Conversation
This script is a copy of Galette core's and had been left on the pre-migration generation, so it carries both the bugs found in the core and the alignment the other plugins already got. Subprocess exit codes were never looked at, so a failed composer install produced an archive without vendor/ while the script exited 0 announcing a release. They now go through one helper that stops the build. `msg` is None on that branch, so `msg +=` raised a TypeError instead of saying what it had found, when a detached signature exists without its archive. The "does this release already exist?" check asked an HTTPS repository on port 80, where the server answers a 301. `status == 200` was therefore false for every version, published or not, and the guard never fired. Also brought in line with the migrated plugins: `/usr/bin/python` no longer exists on a runner, the `urlgrabber` import is dead and is not installed by the shared action, `--no-sign` is what the release workflow passes, `dist/` has to be created on a fresh checkout, and a lightweight tag carries no tag object to read. `assume_yes` moves above the `-f` prompt, which it is supposed to answer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script is a copy of Galette core's and had been left on the pre-migration generation, so it carries both the bugs found in the core and the alignment the other plugins already got.
Subprocess exit codes were never looked at, so a failed composer install produced an archive without vendor/ while the script exited 0 announcing a release. They now go through one helper that stops the build.
msgis None on that branch, somsg +=raised a TypeError instead of saying what it had found, when a detached signature exists without its archive.The "does this release already exist?" check asked an HTTPS repository on port 80, where the server answers a 301.
status == 200was therefore false for every version, published or not, and the guard never fired.Also brought in line with the migrated plugins:
/usr/bin/pythonno longer exists on a runner, theurlgrabberimport is dead and is not installed by the shared action,--no-signis what the release workflow passes,dist/has to be created on a fresh checkout, and a lightweight tag carries no tag object to read.assume_yesmoves above the-fprompt, which it is supposed to answer.