Skip to content

feat(seer): add ThinkingBlock with outline Disclosure - #121329

Open
natemoo-re wants to merge 5 commits into
masterfrom
nm/seer/thinking
Open

feat(seer): add ThinkingBlock with outline Disclosure#121329
natemoo-re wants to merge 5 commits into
masterfrom
nm/seer/thinking

Conversation

@natemoo-re

Copy link
Copy Markdown
Member

Summary

Adds a ThinkingBlock for rendering an agent's "thinking": a collapsible header with the animated Seer glyph, a live-counting elapsed timer, and a bordered body of streamed content.

To support the design cleanly, Disclosure gains:

  • variant="outline" — renders the content panel as a bordered, rounded card.
  • leadingItems on Disclosure.Title — a slot before the toggle (repositions the chevron after the title).
  • widened prop types (accepts StackProps like flex).

Stack

Bottom of a 3-PR stack:

  1. this PRmaster
  2. nm/seer/tool-call → this branch (ToolCall + QueryTokens)
  3. nm/seer/tool-embed → tool-call ({% tool %} embed)

Test plan

  • disclosure.spec.tsx (outline + leadingItems), thinkingBlock.spec.tsx — green.
  • Stories: disclosure.mdx, thinkingBlock.mdx.

@natemoo-re
natemoo-re requested a review from a team as a code owner August 5, 2026 17:15
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-nm55zz7n7.sentry.dev

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 07dd52b. Configure here.

Comment thread static/app/components/core/disclosure/disclosure.tsx
Adds an `outline` variant (bordered content card) and a `leadingItems`
slot (repositions the chevron after the title) to Disclosure, and uses
both in ThinkingBlock.
Drop the unused `async` on a synchronous ThinkingBlock test, and register
thinkingBlock.tsx as a knip production entry (only used in stories/tests
until it is wired into Seer Explorer).
Move the hover/press background from the toggle button to the title row (using
the canonical interactive.transparent tokens) so it sits behind the leading and
trailing items, not just the button between them. Suppress the button's own
hover so the two don't stack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant