Run the conformance suite after the parallel unit test block - #258
Merged
Merged
Conversation
Its parallelism canary asserts two concurrent sleeps finish in under 250ms. Under the all block it competes with five forked test cells and took 582ms on CI. Running it on its own removes that load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kyo compat conformance suite includes a parallelism canary: two concurrent sleeps of 50ms and 100ms must complete in under 250ms. In
testUnitit ran inside theallblock alongside five forked test cells and a set of compiles, and on a two-core runner it took 582ms (run 33932654302 on #257). The suite alone takes about 100ms for that test.This moves
ceConformanceCe/testafter the parallel block so it runs on an idle runner. The bound itself lives in the upstream testkit; a separate change there will replace the wall-clock check with an ordering check that cannot be starved.