Enforce replace-label post-update response checks

[Copilot]

The SPDD review identified that replace_label accepted HTTP 200 responses without verifying the resulting label state. It also identified documentation gaps around observability safeguards and intent-attribution fixture structure.

• Replace-label enforcement

  • Reject successful setLabels responses when the added label is absent.
  • Reject responses retaining a previously present removed label.
  • Emit core.error() with the existing { success: false, error } result shape.

  if (!updatedLabelNames.includes(labelToAdd)) {
    return { success: false, error: "…label_to_add…not found…" };
  }

• Coverage and compliance fixtures

  • Add JavaScript tests for both partial-success response cases.
  • Update RL-057/RL-058/RL-059 fixture documentation and parity date.

• Specification alignment

  • Add the Intent Attribution fixture model’s PolicyCompiler/CLI-reporting structure note.
  • Add consolidated OTel reliability safeguards and fixture-contract references to its implementation map.

• Fixes [spdd] Daily spec work plan - 2026-08-05 #50624

[Copilot]

Pull request overview

Adds post-update validation to replace_label and aligns related specifications and fixtures.

Changes:

• Rejects incomplete setLabels responses and adds regression tests.
• Updates replace-label and intent-attribution compliance documentation.
• Consolidates OTel reliability safeguards and implementation references.

Show a summary per file

File	Description
actions/setup/js/replace_label.cjs	Validates resulting label state.
actions/setup/js/replace_label.test.cjs	Tests partial-success rejection.
specs/replace-label-compliance/README.md	Updates enforcement and parity notes.
specs/intent-attribution-compliance/README.md	Documents policy/report structure.
specs/otel-observability-spec.md	Adds safeguards and implementation references.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 3
• Review effort level: Balanced

[pelikhan]

/matt

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

[github-actions]

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — approving. The implementation correctly closes the RL-057/RL-058/RL-059 spec gap and the new tests cover both partial-success cases cleanly.

📋 Key Themes & Highlights

Positive Highlights

• ✅ Both validation checks guard the right states (label_to_add absent, label_to_remove retained) and are evaluated in a safe order — the labelToRemove !== labelToAdd guard prevents false positives on self-transitions.
• ✅ Test names read as specifications and follow clear Arrange / Act / Assert structure.
• ✅ core.error() + { success: false, error } keeps the error shape consistent with the rest of the handler.
• ✅ Compliance README update is precise: removes the gap note and replaces it with the concrete enforcement statement.
• ✅ OTel safeguards addition is correctly scoped under its own ### Safeguards heading with appropriate MUST-level normative language.

Minor Observation (non-blocking)

The labelToRemoveIsPresent variable referenced by the new guard is defined earlier in the function (outside the diff). Worth confirming it correctly captures the pre-update label presence and is not stale across retries — but the naming is clear and the logic reads correctly.

> 🧠 *Reviewed using Matt Pocock's skills by [Matt Pocock Skills Reviewer](https://github.com/github/gh-aw/actions/runs/31029004356)* · sonnet46 · 27.5 AIC · ⌖ 14.4 AIC · ⊞ 7.1K > _{Comment /matt to run again}

[github-actions]

PR Triage: #50625

Category: feature | Risk: medium | Priority Score: 62/100 (impact 25, urgency 20, quality 17)
Recommended action: batch_review
OTel-related PR — labeled otel; per policy this should be assigned to @mnkeifer for review (no assign tool available to this agent, flagging for manual assignment). CI: impacted-js-tests failing.

Generated by 🔧 PR Triage Agent · auto · 45.2 AIC · ⌖ 2.9 AIC · ⊞ 8K · ◷