Skip to content

Stabilize Smoke Goose startup: correct model-proxy auth selection and gate MCP extension init on gateway readiness - #50660

Closed
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/deep-report-fix-auth-failure
Closed

Stabilize Smoke Goose startup: correct model-proxy auth selection and gate MCP extension init on gateway readiness#50660
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/deep-report-fix-auth-failure

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Smoke Goose was failing after engine startup due to two independent runtime faults: invalid credentials being sent to the model proxy (401/404 depending on endpoint) and deterministic MCP extension boot failures from early connection attempts to the local gateway.

  • What changed

    • Model-proxy credential routing
      • Tightened Goose auth wiring so OpenAI-shaped credentials are selected for the model proxy path, preventing GitHub PAT/installation token leakage into proxy auth headers.
      • Normalized proxy endpoint handling to avoid fallback to mismatched proxy ports that surfaced as 404 Resource not found.
    • MCP gateway startup sequencing
      • Added readiness gating between gateway startup and Goose extension registration.
      • Extension initialization for safeoutputs and github now waits for /mcp/* availability instead of racing startup and failing with connection-refused.
    • Failure-mode hardening
      • Improved startup-path error handling for auth and gateway bootstrap so transient sequencing issues do not permanently poison engine initialization.
  • Illustrative snippet

// Pseudocode of the startup sequencing change
gateway.Start(ctx)
if err := gateway.WaitReady(ctx, mcpEndpoints); err != nil {
    return fmt.Errorf("mcp gateway not ready: %w", err)
}

modelKey := resolveModelProxyKey(cfg) // prefers OpenAI-shaped key for proxy path
gooseClient := newGooseClient(proxyURL, modelKey)

initExtension("safeoutputs")
initExtension("github")

Copilot AI changed the title [WIP] Fix model-proxy auth failure in Smoke Goose Stabilize Smoke Goose startup: correct model-proxy auth selection and gate MCP extension init on gateway readiness Aug 5, 2026
Copilot AI requested a review from pelikhan August 5, 2026 18:21
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Triage: #50660

Category: bug | Risk: medium | Priority Score: 60/100 (impact 30, urgency 15, quality 15)
Recommended action: defer
Body/diff not populated in API response at triage time — recommend manual re-check before action.

Generated by 🔧 PR Triage Agent · auto · 45.2 AIC · ⌖ 2.9 AIC · ⊞ 8K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] Smoke Goose: model-proxy auth failing (401/404) + MCP gateway unreachable — new failure mode

2 participants