Add the Windows peer of darwin-stub - #32
Merged
Merged
Conversation
A fleet-wide audit of the 601 repositories holding Go code put this one a single lane short of the standard: no windows-latest runner. Windows is the fleet's real gap — absent from 327 of 601 (54.4%), where each exotic architecture is missing from only ~189 (31.4%). The `cross` job already builds windows/amd64 and windows/arm64, which proves the module compiles there and nothing more. This runs the suite on a real Windows host, the way darwin-stub already does for macOS. CGO_ENABLED goes in `env` rather than in front of each command: the POSIX prefix darwin-stub uses (`CGO_ENABLED=0 go vet ./...`) is read by PowerShell as a command it cannot find, and that idiom is the reason several repositories in this fleet had no Windows lane at all. Checked before proposing: `go vet` passes with GOOS=windows and every test binary cross-compiles for windows/amd64. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Windows peer of darwin-stub
A fleet-wide audit of the 601 repositories holding Go code put this one a
single lane short of the standard: no windows-latest runner. Windows is the
fleet's real gap — absent from 327 of 601 (54.4%), where each exotic
architecture is missing from only ~189 (31.4%).
The
crossjob already builds windows/amd64 and windows/arm64, which provesthe module compiles there and nothing more. This runs the suite on a real
Windows host, the way darwin-stub already does for macOS.
CGO_ENABLED goes in
envrather than in front of each command: the POSIXprefix darwin-stub uses (
CGO_ENABLED=0 go vet ./...) is read by PowerShellas a command it cannot find, and that idiom is the reason several
repositories in this fleet had no Windows lane at all.
Checked before proposing:
go vetpasses with GOOS=windows and every testbinary cross-compiles for windows/amd64.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com