cocoa: put a control picture on the real button - #104
Merged
Conversation
A toolbar is icons. This passes a Native picture through to the NSImage behind it (go-macos/appkit v0.4.0, go-widgets/toolkit v0.306.0). Only when it changed, and compared by CONTENT: the application rebuilds its descriptor every frame, so a fresh slice holding the same picture is the same picture. Decoding a PNG sixty times a second to hand AppKit what it already has is work for nothing, and it makes a button flicker as its cell is replaced under the pointer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A toolbar is icons. This passes a
Nativepicture through to the NSImage behind it (go-macos/appkit v0.4.0, go-widgets/toolkit v0.306.0).Only when it changed, and compared by content: the application rebuilds its descriptor every frame, so a fresh slice holding the same picture is the same picture. Decoding a PNG sixty times a second to hand AppKit what it already has is work for nothing, and it makes a button flicker as its cell is replaced under the pointer.
Consumer:
godl queue windowtoolbar.🤖 Generated with Claude Code