win32: host Search, TextView and editable Combo - #107
Merged
Conversation
The three of the ten new kinds that reuse control classes this backend already creates successfully, so they are safe to add even though the fleet has no Windows to run them on: Search→EDIT (as Entry), TextView→EDIT (ES_MULTILINE|ES_WANTRETURN| WS_VSCROLL), Combo→editable COMBOBOX (CBS_DROPDOWN, so it has an edit field). Each takes its value via WM_SETTEXT and reports via WM_COMMAND (EN_CHANGE for the EDITs, CBN_EDITCHANGE/CBN_SELCHANGE for the combo). Cross-built for windows/amd64+arm64. The other seven new kinds (Progress, Spinner, Stepper, Segmented, Link, Date, Color) still fall back to the drawn control on Windows: they need new common-control classes (msctls_progress32/updown32, SysDateTimePick32, SysLink) whose value messages and WM_NOTIFY routing cannot be validated without a real Windows session, so they are left for a Windows test pass rather than written blind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three of the ten new kinds that reuse control classes this backend already creates (EDIT, COMBOBOX), so they are safe without a Windows run: Search→EDIT, TextView→EDIT (multi-line), Combo→editable COMBOBOX (CBS_DROPDOWN). Value via WM_SETTEXT; reported via EN_CHANGE / CBN_EDITCHANGE. Cross-built windows/amd64+arm64.
The other seven (Progress, Spinner, Stepper, Segmented, Link, Date, Color) still fall back to the drawn control on Windows — they need new common-control classes whose messages/WM_NOTIFY can't be validated without a Windows session, left for a Windows pass rather than written blind.