Run the docs check on pull requests, not only on main - #5
Merged
Conversation
The deploy workflow already gates on `npm run check`, so a dead link or an out-of-sync translation cannot reach the site. But it only runs on main, so the failure lands after the merge: main goes red, and the site quietly keeps serving the previous build until someone notices and pushes a fix. Same command, same Node version, on the pull request instead -- where it can still be acted on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy workflow already gates on
npm run check, so a dead link or anout-of-sync translation can't reach the published site. But it only runs on
main, which means the failure arrives after the merge:maingoes red andthe site quietly keeps serving the previous build until someone notices.
This runs the same command, on the same Node version, on the pull request —
where it can still be acted on. Nothing else changes;
deploy.ymlkeeps its owngate.
Noticed while adding the platform/binary-size section in
#4, which had no
check to wait on.
🤖 Generated with Claude Code