Fix conditional method typing - #220
Open
rushi806 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a mypy type-checking error in src/galaxy/api/plugin.py.
The _register_method() function previously defined method() differently depending on the immediate condition:
A synchronous method() when immediate=True
An asynchronous method() when immediate=False
This caused mypy to report:
All conditional function variants must have identical signatures
The implementation was refactored so that method() has a single definition while preserving the existing synchronous and asynchronous behavior.
Testing
mypy src — passed
pytest — passed
No unrelated files or functionality were changed.
Note
This change addresses the mypy/type-checking issue. It should not be described as fixing GitHub Issue #167 unless the maintainer confirms that this change is directly related to that issue.