fix: await definitive ClawHub publication - #438
Merged
Conversation
Bundle Size Report
|
Greptile SummaryThe PR updates the pinned ClawHub CLI and changes the release workflow to await the definitive publication-attempt result before verifying the retained tarball.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects identified. The workflow now waits for ClawHub’s definitive publication result and verifies the same retained artifact afterward, while the added tests cover the intended release-workflow contract.
|
| Filename | Overview |
|---|---|
| .github/workflows/release.yml | Pins ClawHub 0.23.3 and waits for the exact publication attempt to reach a definitive state before verifying the artifact. |
| tests/release-workflow.test.ts | Adds focused, CI-discovered text-contract tests for the CLI pin, publication wait sequence, and removal of fixed sleeps. |
Sequence Diagram
sequenceDiagram
participant Workflow as Release workflow
participant CLI as ClawHub CLI 0.23.3
participant Hub as ClawHub
Workflow->>CLI: package publish --wait --wait-timeout 2400
CLI->>Hub: Upload artifact
loop Poll exact publication attempt
CLI->>Hub: Request publication state
Hub-->>CLI: Pending or terminal state
end
CLI-->>Workflow: Published or non-zero terminal failure
Workflow->>CLI: package verify exact tarball
CLI->>Hub: Resolve published artifact metadata
CLI-->>Workflow: Verification result
Reviews (1): Last reviewed commit: "fix: await definitive ClawHub publicatio..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
ClawHub package publication is two-phase. CLI 0.23.1 returned after upload acceptance with a
releaseId, before pre-publication security checks finalized the version.package verifyreads the public version endpoint, so the existing 5/10/20/40/60 loop repeatedly sawVersion not found(and rate-limit reset metadata) while the exact publication attempt was still pending. ClawHub 0.23.3 adds authenticated--waitpolling of that exact attempt and fails closed on blocked, failed, expired, or timed-out states.Verification
pnpm test:file tests/release-workflow.test.tspnpm verifypnpm check-plugin-securitypnpm validate:release-metadata -- 4.7.10pnpm audit:prodpnpm verify:npm-consumeractionlintgit diff --checkNo local plugin installation or Gateway restart is included.