elanspi: Add PID 04F3:3128 support and enable SIGFM OpenCV matcher - #43
Open
manishdhiman1 wants to merge 2 commits into
Open
elanspi: Add PID 04F3:3128 support and enable SIGFM OpenCV matcher#43manishdhiman1 wants to merge 2 commits into
manishdhiman1 wants to merge 2 commits into
Conversation
added 2 commits
September 13, 2026 12:08
- Add ELAN7001 / PID 04F3:3128 (ASUS VivoBook) to elanspi_id_table with ELANSPI_180_ROTATE. - Tune motion standard deviation thresholds (MIN_REAL_STDDEV, MAX_EMPTY_STDDEV). - Tune swipe frame limits for small 80x80 sensor capture.
- Switch elanspi to FPI_DEVICE_ALGO_SIGFM with threshold 30. - Add separable Gaussian smoothing pass to suppress capacitive SPI speckle noise. - Maintain native image resolution to preserve ridge frequency details. - Tolerate short 1-2 frame empty gaps during continuous finger swipes instead of discarding accumulated frames. - Lower minimum keypoint requirement in fp-image to prevent rejecting partial swipes.
manishdhiman1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the ELAN SPI sensor
ELAN7001(PID04F3:3128, found in ASUS VivoBook X415EA and similar laptops) and switches theelanspidriver to use the OpenCV SIFT matcher (FPI_DEVICE_ALGO_SIGFM).Problem
The ELAN7001 internal sensor is a small 80×80 pixel matrix. In Linux, it runs in swipe-stitch mode. Because only 1–3 minutiae points can be extracted from each swipe on this small sensor, the default NBIS
bozorth3matcher mathematically fails (always returning score 0 /verify-no-match).Changes
ELAN7001/ PID04F3:3128withELANSPI_180_ROTATEtoelanspi_id_table.FPI_DEVICE_ALGO_SIGFMwith threshold30.fp_empty_counter <= 2), preventing the driver from prematurely wiping accumulated swipe frames.fp-image.cfrom 25 to 5 to tolerate small swipe profiles.Testing & Verification
04F3:3128onspidev0.0).sudo, system login, andfprintd-verify.sigfm-tests): 7/7 passed.