Skip to content

test(virtio): add tests for VirtioPciRegisterMmio #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lencerf merged 2 commits into from
Aug 28, 2026
Merged

test(virtio): add tests for VirtioPciRegisterMmio #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51dfa53
fix(virtio): validate queue size in split and packed queues
Lencerf Aug 28, 2026
6a92f6f
test(virtio): add tests for VirtioPciRegisterMmio
Lencerf Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alioth/src/hv/hv_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ impl IrqFd for TestIrqFd {

impl AsFd for TestIrqFd {
fn as_fd(&self) -> BorrowedFd<'_> {
unreachable!()
unsafe { BorrowedFd::borrow_raw(0) }
}
}

Expand Down
10 changes: 9 additions & 1 deletion alioth/src/virtio/pci.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,15 @@ where
if let Some(q) = self.queues.get(q_sel)
&& !q.enabled.load(Ordering::Acquire)
{
q.size.store(val as u16, Ordering::Release);
if val.is_power_of_two()
|| VirtioFeature(self.reg.get_driver_feature())
.contains(VirtioFeature::RING_PACKED)
&& val > 0
{
q.size.store(val as u16, Ordering::Release);
} else {
log::warn!("{}: queue {q_sel}: invalid queue size: {val}", self.name);
}
}
}
VirtioCommonCfg::LAYOUT_QUEUE_MSIX_VECTOR => {
Expand Down
Loading