Skip to content

Support target configuration preset in Cuttlefish cvd load JSON - #3067

Open
cjreynol wants to merge 1 commit into
google:version-1.56-devfrom
cjreynol:support-config-preset-load-cvd-backport-2
Open

Support target configuration preset in Cuttlefish cvd load JSON#3067
cjreynol wants to merge 1 commit into
google:version-1.56-devfrom
cjreynol:support-config-preset-load-cvd-backport-2

Conversation

@cjreynol

Copy link
Copy Markdown
Collaborator

Backport of #3034

Summary

Adds support for specifying a target configuration preset in Cuttlefish cvd load JSON configurations.

  • Adds optional string config = 11; to message Instance in load_config.proto.
  • Updates cf_configs_instances.cpp to emit --config= per instance when configured, allowing cvd load and cloud orchestrators to pass configuration presets natively in JSON.
  • Adds comprehensive unit test coverage in flags_parser_test.cc for single-instance, multi-instance, and partial multi-instance scenarios.

Test

Added unit tests in flags_parser_test.cc:

  • ConfigFlagsParserTest.ParseSingleInstanceConfig
  • ConfigFlagsParserTest.ParseMultiInstanceConfig
  • ConfigFlagsParserTest.ParseMultiInstanceConfigPartial

@cjreynol
cjreynol requested a review from Databean August 20, 2026 20:37
@cjreynol cjreynol self-assigned this Aug 20, 2026
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Aug 20, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Aug 20, 2026
@cjreynol
cjreynol force-pushed the support-config-preset-load-cvd-backport-2 branch from cd084c2 to a200604 Compare August 21, 2026 23:30
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Aug 21, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Aug 21, 2026
Adds optional string config = 11 to message Instance in load_config.proto.
Updates cf_configs_instances.cpp to emit --config=<preset> per instance,
allowing cvd load and cloud orchestrators to pass configuration presets
natively in JSON.
@cjreynol
cjreynol force-pushed the support-config-preset-load-cvd-backport-2 branch from a200604 to 0e6fa50 Compare August 22, 2026 00:07
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Aug 22, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants