Always build crosvm in opt mode - #3072
Merged
Merged
Conversation
This has two effects: - Disables debug assertions crash over an IO safety issue in sandbox mode. - Improves VM runtime performance. With this change, we are closer to being able to package crosvm in `//cuttlefish/package:common`. Bug: b/402274999
Member
Author
|
This is most of #3008 but doesn't actually package it yet. |
Member
Is there more info on this or why we think it is benign? This sounds pretty scary at least. |
Member
Author
I'm not really sure that it is benign :/ the error looks like This check is https://www.github.com/rust-lang/rust/pull/124210 which was added to stable in Rust 1.80. Crosvm upstream is using Rust 1.88.0 so it is surprising we're seeing this error now. I can't reproduce this with a |
jemoreira
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two effects:
With this change, we are closer to being able to package crosvm in
//cuttlefish/package:common.Bug: b/402274999