Always run snapshot_hook_* as root - #3076
Merged
cjreynol merged 1 commit intoAug 21, 2026
Merged
Conversation
When not run as root, this produces errors like ``` + /system/bin/cmd nfc status + grep -q disabled /vendor/bin/snapshot_hook_pre_suspend[40]: grep: inaccessible or not found + sleep 0.1 /vendor/bin/snapshot_hook_pre_suspend[40]: sleep: inaccessible or not found ``` This may have worked intermittently before depending on whether the runtime environment was also using `adb root`. Bug: b/534832487
Databean
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2860 (and finish matching the
1.56mirror of #2979)When not run as root, this produces errors like
This may have worked intermittently before depending on whether the runtime environment was also using
adb root.Bug: b/534832487