Fix PropertySetter handling of TYPE_USE nullable - #2112
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_960135243
branch
from
August 10, 2026 06:57
3930fa7 to
22d6d7c
Compare
javac has a bug (https://bugs.openjdk.org/browse/JDK-8389859) where annotations that target both `TYPE_USE` and declaration targets only appear on the declaration if the type use is a type variable. This doesn't happen for other non-type variable type uses, or annotations that are exclusively targeting `TYPE_USE`. For example in `<T> void f(@nullable T t) {}` javac will not report the annotation as being on the parameter's `TypeMirror`, just the `Element`. In AutoBuilder, PropertySetter was checking the `AnnotatedTypeMirror#getType` for `TYPE_USE` annotations, which was incorrectly checking the derived type created by `asMemberOf` that removes type annotations, instead of checking `AnnotatedTypeMirror#annotations`. The path that actually printed the type was using `AnnotatedTypeMirror#annotations`. RELNOTES=n/a PiperOrigin-RevId: 961970022
copybara-service
Bot
force-pushed
the
test_960135243
branch
from
August 10, 2026 07:00
22d6d7c to
383ff77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PropertySetter handling of TYPE_USE nullable
javac has a bug (https://bugs.openjdk.org/browse/JDK-8389859) where annotations
that target both
TYPE_USEand declaration targets only appear on thedeclaration if the type use is a type variable. This doesn't happen for other
non-type variable type uses, or annotations that are exclusively targeting
TYPE_USE.For example in
<T> void f(@Nullable T t) {}javac will not report theannotation as being on the parameter's
TypeMirror, just theElement.In AutoBuilder, PropertySetter was checking the
AnnotatedTypeMirror#getTypefor
TYPE_USEannotations, which was incorrectly checking the derived typecreated by
asMemberOfthat removes type annotations, instead of checkingAnnotatedTypeMirror#annotations. The path that actually printed the type wasusing
AnnotatedTypeMirror#annotations.RELNOTES=n/a