Skip to content

Add tests for TYPE_USE annotations on outer classes and arrays #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 10, 2026
Merged

Add tests for TYPE_USE annotations on outer classes and arrays #2113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 169 additions & 0 deletions value/src/test/java/com/google/auto/value/processor/AutoValueCompilationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4293,6 +4293,175 @@ public void notNullOnOuterClassWithNullableInnerType() {
.hasSourceEquivalentTo(expectedOutput);
}

@Test
public void notNullTypeUseAnnotationOnOuterClass() {
assume().that(typeAnnotationsWork).isTrue();
JavaFileObject javaFileObject =
JavaFileObjects.forSourceLines(
"foo.bar.Baz",
"package foo.bar;",
"",
"import com.google.auto.value.AutoValue;",
"import java.lang.annotation.ElementType;",
"import java.lang.annotation.Target;",
"",
"@AutoValue",
"public abstract class Baz {",
" @Target({ElementType.TYPE_USE, ElementType.METHOD, ElementType.PARAMETER})",
" public @interface NotNull {}",
"",
" @NotNull",
" abstract Outer.Inner inner();",
"",
" @AutoValue.Builder",
" public abstract static class Builder {",
" public abstract Builder setInner(Outer.Inner inner);",
" public abstract Baz build();",
" }",
"}",
"class Outer {",
" class Inner {}",
"}");
// TODO(b/540040170): Fix the duplicate annotation bug that causes compilation failure.
Compilation compilation =
javac()
.withProcessors(new AutoValueProcessor(), new AutoValueBuilderProcessor())
.compile(javaFileObject);
assertThat(compilation)
.hadErrorContaining("foo.bar.Baz.NotNull is not a repeatable annotation");
}

@Test
public void notNullTypeUseAnnotationOnStaticOuterClass() {
assume().that(typeAnnotationsWork).isTrue();
JavaFileObject javaFileObject =
JavaFileObjects.forSourceLines(
"foo.bar.Baz",
"package foo.bar;",
"",
"import com.google.auto.value.AutoValue;",
"import java.lang.annotation.ElementType;",
"import java.lang.annotation.Target;",
"",
"@AutoValue",
"public abstract class Baz {",
" @Target({ElementType.TYPE_USE, ElementType.METHOD, ElementType.PARAMETER})",
" public @interface NotNull {}",
"",
" @NotNull",
" abstract Outer.Inner inner();",
"",
" @AutoValue.Builder",
" public abstract static class Builder {",
" public abstract Builder setInner(Outer.Inner inner);",
" public abstract Baz build();",
" }",
"}",
"class Outer {",
" static class Inner {}",
"}");
// Type-use annotations on static nested classes are associated directly with the member type
// rather than an enclosing instance type (JLS 9.7.4), so annotation propagation works
// correctly.
Compilation compilation =
javac()
.withProcessors(new AutoValueProcessor(), new AutoValueBuilderProcessor())
.compile(javaFileObject);
assertThat(compilation).succeeded();
assertThat(compilation)
.generatedSourceFile("foo.bar.AutoValue_Baz")
.contentsAsUtf8String()
.contains(
" @Baz.NotNull\n"
+ " @Override\n"
+ " Outer.Inner inner() {\n"
+ " return inner;\n"
+ " }\n");
assertThat(compilation)
.generatedSourceFile("foo.bar.AutoValue_Baz")
.contentsAsUtf8String()
.contains("private Outer.@Nullable Inner inner;");
}

@Test
public void nullableTypeUseAnnotationOnOuterClass() {
assume().that(typeAnnotationsWork).isTrue();
JavaFileObject javaFileObject =
JavaFileObjects.forSourceLines(
"foo.bar.Baz",
"package foo.bar;",
"",
"import com.google.auto.value.AutoValue;",
"import java.lang.annotation.ElementType;",
"import java.lang.annotation.Target;",
"",
"@AutoValue",
"public abstract class Baz {",
" @Target({ElementType.TYPE_USE, ElementType.METHOD, ElementType.PARAMETER})",
" public @interface Nullable {}",
"",
" @Nullable",
" abstract Outer.Inner inner();",
"",
" @AutoValue.Builder",
" public abstract static class Builder {",
" public abstract Builder setInner(Outer.Inner inner);",
" public abstract Baz build();",
" }",
"}",
"class Outer {",
" class Inner {}",
"}");
// TODO(b/540040170): Fix the duplicate annotation bug that causes compilation failure.
Compilation compilation =
javac()
.withProcessors(new AutoValueProcessor(), new AutoValueBuilderProcessor())
.compile(javaFileObject);
assertThat(compilation)
.hadErrorContaining("foo.bar.Baz.Nullable is not a repeatable annotation");
}

@Test
public void notNullTypeUseAnnotationOnArray() {
assume().that(typeAnnotationsWork).isTrue();
JavaFileObject javaFileObject =
JavaFileObjects.forSourceLines(
"foo.bar.Baz",
"package foo.bar;",
"",
"import com.google.auto.value.AutoValue;",
"import java.lang.annotation.ElementType;",
"import java.lang.annotation.Target;",
"",
"@AutoValue",
"public abstract class Baz {",
" @Target({",
" ElementType.TYPE_USE,",
" ElementType.FIELD,",
" ElementType.PARAMETER,",
" ElementType.METHOD",
" })",
" public @interface NotNull {}",
"",
" @SuppressWarnings(\"mutable\")",
" @NotNull",
" abstract byte[] bytes();",
"",
" @AutoValue.Builder",
" public abstract static class Builder {",
" public abstract Builder setBytes(byte[] bytes);",
" public abstract Baz build();",
" }",
"}");
// TODO(b/540040170): Fix the duplicate annotation bug that causes compilation failure.
Compilation compilation =
javac()
.withProcessors(new AutoValueProcessor(), new AutoValueBuilderProcessor())
.compile(javaFileObject);
assertThat(compilation)
.hadErrorContaining("foo.bar.Baz.NotNull is not a repeatable annotation");
}

private static String sorted(String... imports) {
return stream(imports).sorted().collect(joining("\n"));
}
Expand Down
Loading