Feature - add <Coordinated Set Name> characteristic to csip.py - #977
Open
markusjellitsch wants to merge 3 commits into
Open
Feature - add <Coordinated Set Name> characteristic to csip.py#977markusjellitsch wants to merge 3 commits into
markusjellitsch wants to merge 3 commits into
Conversation
barbibulle
reviewed
Sep 8, 2026
| coordinated_set_size: gatt_client.CharacteristicProxy[bytes] | None = None | ||
| set_member_lock: gatt_client.CharacteristicProxy[bytes] | None = None | ||
| set_member_rank: gatt_client.CharacteristicProxy[bytes] | None = None | ||
| coordinated_set_name: gatt_client.CharacteristicProxy[bytes] | None = None |
Collaborator
There was a problem hiding this comment.
It would be even more convenient to use an adapter here, so that string decoding happens automatically. Use a UTF8CharacteristicProxyAdapter.
(see the audio_input_description charactertistic from aics.py for an example).
The adapter isn't really needed on the server side, since that value is static, so the conversion to bytes might as well be done inline in the constructor, like you have here, but on the client side, it's dynamic.
Contributor
Author
There was a problem hiding this comment.
agree...this makes sense.
I have updated the client (and test) to now use the UTF8CharacteristicProxyAdapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, the Bluetooth SIG adopted CSIS (Coordinated Set Identification Service) v1.1, which introduces a
new optional characteristic: Coordinated Set Name (UUID 0x2C1A). This PR adds the characteristic to
csip,py. Moreover, tests have been added intest_csip.pyAccording to Spec.: