fix: avoid extra blank line after unused import removal (#1436) - #1437
Open
arimu1 wants to merge 1 commit into
Open
fix: avoid extra blank line after unused import removal (#1436)#1437arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
When every import between the package blank and the type blank is removed, collapse one of the stacked blank lines so a single CLI pass stays style-compliant (format-then-fix-imports path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1436.
When unused imports between a
packagedeclaration and a class Javadoc/declaration are removed, the blank line that preceded the import block and the blank line that followed it were both left in place. The CLI path formats first and then fixes imports, so those stacked blanks were never re-normalized in the same pass (a second format pass fixed them).This change:
RangeMap.putCoalescing)Test plan
RemoveUnusedImportsTest— includes unused import removal leaves extra blank line between package declaration and class Javadoc / declaration #1436 package + unused import + class Javadoc, multi-unused, leading-import-only, and partial-unused casesMainTest#unusedImportRemovalDoesNotLeaveDoubleBlankBeforeJavadoc— CLIMain.formatpath (format-then-fix-imports)mvn -pl core -am test -Dtest=RemoveUnusedImportsTest,RemoveUnusedImportsCaseLabelsTest,FormatterTest,MainTest,ImportOrdererTest→ 115/115 (Temurin 21)package+ single blank + javadoc)