Skip to content

Move MapConfig and related constants to :core:domain - #3903

Merged
shobhitagarwal1612 merged 4 commits into
masterfrom
stores
Aug 27, 2026
Merged

Move MapConfig and related constants to :core:domain#3903
shobhitagarwal1612 merged 4 commits into
masterfrom
stores

Conversation

@shobhitagarwal1612

Copy link
Copy Markdown
Member

Towards #3633

Migrates base map configuration and common domain constants from :app to :core:domain as part of the ongoing KMP migration:

  • Moved MapConfig from org.groundplatform.android.ui.common to org.groundplatform.domain.model.map.MapConfig.
  • Added property-level KtDocs and default values to MapConfig.
  • Relocated domain/map constants (DEFAULT_LOI_ZOOM_LEVEL, CLUSTERING_ZOOM_THRESHOLD, TEXT_DATA_CHAR_LIMIT, DEFAULT_MAP_TYPE, ACCURACY_THRESHOLD_IN_M) from app/common/Constants.kt to org.groundplatform.domain.util.Constants.
  • Updated all imports and call sites across fragments, view models, and unit tests in :app.
  • Added MapConfigTest in :core:domain:commonTest covering default values, custom overrides, and copy mutations.

@andreia-ferreira PTAL?

@shobhitagarwal1612 shobhitagarwal1612 changed the title Move map configuration and constants to :core:domain Move MapConfig and related constants to :core:domain Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.98%. Comparing base (14f15ed) to head (0d1395f).

Files with missing lines Patch % Lines
.../android/ui/common/AbstractMapContainerFragment.kt 25.00% 3 Missing ⚠️
...kotlin/org/groundplatform/domain/util/Constants.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3903      +/-   ##
============================================
- Coverage     68.98%   68.98%   -0.01%     
- Complexity     1942     1946       +4     
============================================
  Files           412      413       +1     
  Lines         10963    10964       +1     
  Branches       1429     1429              
============================================
  Hits           7563     7563              
- Misses         2655     2656       +1     
  Partials        745      745              
Files with missing lines Coverage Δ
...ava/org/groundplatform/android/common/Constants.kt 50.00% <ø> (-16.67%) ⬇️
...oundplatform/android/data/local/LocalValueStore.kt 86.66% <ø> (ø)
...oundplatform/android/ui/common/BaseMapViewModel.kt 63.49% <ø> (ø)
...roid/ui/datacollection/components/TextTaskInput.kt 77.27% <ø> (ø)
...ui/datacollection/tasks/AbstractTaskMapFragment.kt 60.27% <ø> (ø)
...n/tasks/location/CaptureLocationTaskMapFragment.kt 0.00% <ø> (ø)
...ion/tasks/location/CaptureLocationTaskViewModel.kt 93.47% <ø> (ø)
...ion/tasks/multiplechoice/MultipleChoiceItemView.kt 50.66% <ø> (ø)
...asks/multiplechoice/MultipleChoiceTaskViewModel.kt 80.32% <ø> (ø)
.../ui/datacollection/tasks/text/TextTaskViewModel.kt 75.00% <ø> (ø)
... and 7 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shobhitagarwal1612
shobhitagarwal1612 merged commit 21d627e into master Aug 27, 2026
19 checks passed
@shobhitagarwal1612
shobhitagarwal1612 deleted the stores branch August 27, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants