Move MapConfig and related constants to :core:domain - #3903
Merged
Conversation
… and add MapConfig tests
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3903 +/- ##
============================================
- Coverage 68.98% 68.98% -0.01%
- Complexity 1942 1946 +4
============================================
Files 412 413 +1
Lines 10963 10964 +1
Branches 1429 1429
============================================
Hits 7563 7563
- Misses 2655 2656 +1
Partials 745 745
🚀 New features to boost your workflow:
|
…cross UI fragments
shobhitagarwal1612
requested a deployment
to
e2e-approval
August 27, 2026 11:21 — with
GitHub Actions
Waiting
shobhitagarwal1612
requested a deployment
to
e2e-approval
August 27, 2026 11:21 — with
GitHub Actions
Waiting
andreia-ferreira
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3633
Migrates base map configuration and common domain constants from
:appto:core:domainas part of the ongoing KMP migration:MapConfigfromorg.groundplatform.android.ui.commontoorg.groundplatform.domain.model.map.MapConfig.MapConfig.DEFAULT_LOI_ZOOM_LEVEL,CLUSTERING_ZOOM_THRESHOLD,TEXT_DATA_CHAR_LIMIT,DEFAULT_MAP_TYPE,ACCURACY_THRESHOLD_IN_M) fromapp/common/Constants.kttoorg.groundplatform.domain.util.Constants.:app.MapConfigTestin:core:domain:commonTestcovering default values, custom overrides, and copy mutations.@andreia-ferreira PTAL?